Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github-action #43

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

gardar
Copy link
Contributor

@gardar gardar commented Jan 8, 2024

Adoption of the action from https://github.com/rndmh3ro/antsichaut-action since I felt like the action got a bit lost in a separate repo.

fixes #2

@rndmh3ro
Copy link
Collaborator

rndmh3ro commented Jan 8, 2024

Thanks, initially I didn't want to further develop the action and actually thought it didn't work. :)
But since you're using it it seems to work. :)

The missing parameters can be added once someone needs them.

@rndmh3ro
Copy link
Collaborator

rndmh3ro commented Jan 8, 2024

Can you please make an exception for the spelling-problems found?

@gardar
Copy link
Contributor Author

gardar commented Jan 8, 2024

Thanks, initially I didn't want to further develop the action and actually thought it didn't work. :)
But since you're using it it seems to work. :)

Haha that's funny, yeah it's working fine, I didn't know it wasn't supposed to work 😀

Can you please make an exception for the spelling-problems found?

I think I got it, added regex to ignore code blocks in markdown according to this: streetsidesoftware/vscode-spell-checker#202 (comment)

@rndmh3ro rndmh3ro added enhancement New feature or request minor labels Jan 8, 2024
@rndmh3ro rndmh3ro merged commit 66464bb into ansible-community:main Jan 9, 2024
4 checks passed
@rndmh3ro
Copy link
Collaborator

rndmh3ro commented Jan 9, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Github Action
2 participants