find hidden files in /var/log for 4.3.2 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
|
hi @Corey0219 Thank you for taking the time to raise this PR. Happy to pull this in but have noticed it is missing a gpg signature on sign off. If you are able to add this am happy to merge this PR. Thanks again uk-bolly |
Corey0219
force-pushed
the
update-4-2-3
branch
from
672dbb0 to
5688c9e
Compare
|
Sorry this has taken so long to complete. Is commit signiture correct now @uk-bolly ? |
Signed-off-by: Corey Reid <[email protected]>
Corey0219
force-pushed
the
update-4-2-3
branch
from
5688c9e to
8d85f17
Compare
uk-bolly
approved these changes
Dec 20, 2023
|
hi @Corey0219 Perfect the PR accepted and merged all sorted. Thank you uk-bolly |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Allow the find module to find hidden file in /var/log/
Issue Fixes:
Addresses a failure on section [4.2.3 Ensure permission on all log files are configured]. The issue is that when using VMware guest customisation to provision VMs, it produce a hidden file “/var/log/.vmware-deploy.Done”. The find module defaults to hidden: false and so is not fixing this permissions issue in a later step.
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?:
Tested against AlmaLinux 9.2 VM provisioned in vSphere