Fix inject_facts_as_vars #115
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
Also enabled testing of this in CI to prevent regressions. See: - https://docs.ansible.com/ansible/2.9/reference_appendices/config.html#inject-facts-as-vars - ansible-lockdown#54 Signed-off-by: Will Szumski <[email protected]>
Signed-off-by: Will Szumski <[email protected]>
jovial
force-pushed
the
bugfix/inject-facts
branch
from
917d488 to
81594cb
Compare
|
hi @jovial Thank you for taking the time to raise this PR, unfortunatley i have noticed that the GPG signature is missing from the commit. If you could possibly add that i am happy to merge. Many thanks uk-bolly |
Hi @jovial I am hoping to get round and update these early in the new year. If you can get this GPG signed happy to accept the PR. Thank you once again uk-bolly |
|
hi @jovial We will be pushing a new release shortly. I would like to include this change, if you could please ensure it is signed off and gpg signed correctly so we can incorporate the changes into the upcoming release. Many thanks uk-bolly |
Signed-off-by: Mark Bolwell <[email protected]>
* change logic thanks to @rjacobs1990 see #175 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @ipruteani-sie #134 Signed-off-by: Mark Bolwell <[email protected]> * Thanks to @stwongst #125 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @sgomez86 #146 Signed-off-by: Mark Bolwell <[email protected]> * Added updates from #115 Signed-off-by: Mark Bolwell <[email protected]> * removed rp_filter in post added in error Signed-off-by: Mark Bolwell <[email protected]> * updated yamllint precommit Signed-off-by: Mark Bolwell <[email protected]> * updated fqcn fo json_query Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * fix typo for virt type query Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]>
* change logic thanks to @rjacobs1990 see ansible-lockdown#175 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @ipruteani-sie ansible-lockdown#134 Signed-off-by: Mark Bolwell <[email protected]> * Thanks to @stwongst ansible-lockdown#125 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @sgomez86 ansible-lockdown#146 Signed-off-by: Mark Bolwell <[email protected]> * Added updates from ansible-lockdown#115 Signed-off-by: Mark Bolwell <[email protected]> * removed rp_filter in post added in error Signed-off-by: Mark Bolwell <[email protected]> * updated yamllint precommit Signed-off-by: Mark Bolwell <[email protected]> * updated fqcn fo json_query Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * fix typo for virt type query Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]>
|
hi @jovial I have incorporated this change in to the latest feb24 updates and is now in devel branch. kindest regards uk-bolly |
* change logic thanks to @rjacobs1990 see ansible-lockdown#175 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @ipruteani-sie ansible-lockdown#134 Signed-off-by: Mark Bolwell <[email protected]> * Thanks to @stwongst ansible-lockdown#125 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @sgomez86 ansible-lockdown#146 Signed-off-by: Mark Bolwell <[email protected]> * Added updates from ansible-lockdown#115 Signed-off-by: Mark Bolwell <[email protected]> * removed rp_filter in post added in error Signed-off-by: Mark Bolwell <[email protected]> * updated yamllint precommit Signed-off-by: Mark Bolwell <[email protected]> * updated fqcn fo json_query Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * fix typo for virt type query Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]>
Also enabled testing of this in CI to prevent regressions.
See:
Overall Review of Changes:
A general description of the changes made that are being requested for merge
Issue Fixes:
Please list (using linking) any open issues this PR addresses
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?:
Tested locally and have enabled testing of this in CI to prevent regressions.