Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHBK/KC v26 #254

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

hwo-wd
Copy link
Collaborator

@hwo-wd hwo-wd commented Dec 5, 2024

Important Docs:

Known upstream issues, relevant for ppl thinking about upgrading to RHBK 26 just yet:

@guidograzioli this one has quite some braking changes, most noteworthy hostname v2 and I was unsure about the way to deal with it: on the one hand, keycloak will move forward with hostname v2 (and that's what I implemented), on the other hand, there could be a try to be downwards compatible.
However, the relative_path option confuses me still a bit: it needs to be part of the keycloak_quarkus_hostname var but should also be set in the http_relative_path; the latter is now really only used for ressources and the thing that really matters is keycloak_quarkus_hostname.
This, of course, is even more important for RH-SSO users wanting to upgrade and who are stuck with /auth keyword.

I've tried in deprecations.yaml to mitigate some of the issues, but in my personal opinion I would go the route that the playbook exits when legacy hostname vars are used such that the user is forced to upgrade to keycloak_quarkus_hostname.

Alltogether this will be a v3 one way or the other, but let me know your thoughts, thx

@hwo-wd hwo-wd marked this pull request as draft December 5, 2024 12:28
@hwo-wd hwo-wd force-pushed the feature/253_rhbk_v26 branch 18 times, most recently from e5d80fd to c708770 Compare December 12, 2024 15:23
…ve_path options

RHBK v26 exposes health endpoints and metrics on this port moving forward.
Note that the scheme of the MGMT interface is defined by the overall keycloak configuration: if https is enabled and configured, th MGMT interface is exposed via https and NOT via http; this might be breaking some configured load balancer health checks
@hwo-wd hwo-wd force-pushed the feature/253_rhbk_v26 branch from 6ffc78e to 07925d0 Compare December 13, 2024 11:12
@hwo-wd hwo-wd requested a review from guidograzioli December 13, 2024 11:23
@hwo-wd hwo-wd marked this pull request as ready for review December 13, 2024 11:23
@hwo-wd hwo-wd force-pushed the feature/253_rhbk_v26 branch from 07925d0 to 1bf21bd Compare January 9, 2025 11:16
@hwo-wd hwo-wd force-pushed the feature/253_rhbk_v26 branch from 1bf21bd to 86284b1 Compare January 9, 2025 11:17
@idNoRD
Copy link

idNoRD commented Jan 18, 2025

Hi @hwo-wd I tried your changes and got this error:

Unexpected templating type error occurred on ({{ keycloak_quarkus_health_check_url | default(keycloak_quarkus_hostname + '/' + (keycloak_quarkus_health_check_url_path | default('realms/master/.well-known/openid-configuration'))) }}): unsupported operand type(s) for +: 'NoneType' and 'str'. unsupported operand type(s) for +: 'NoneType' and 'str'

As a solution I propose to replace + with ~ because ~ operator in Jinja2 can handle None gracefully.

@hwo-wd
Copy link
Collaborator Author

hwo-wd commented Jan 20, 2025

Thanks, @idNoRD, today I learned ;-).
Would you mind giving it another try? -- Thanks

@guidograzioli any thoughts about this PR from your side?
Update: molecule tests are failing now due to:

fatal: [instance]: FAILED! => {"changed": false, "module_stderr": "sudo: PAM account management error: Authentication service cannot retrieve authentication info\nsudo: a password is required\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants