Reorder nginx container resource requirements in template to fix syntax #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rooftopcellist
force-pushed
the
fix-order-nginx-resource-requirements
branch
from
40f0b92 to
89c546d
Compare
|
rcarrillocruz
approved these changes
Jan 9, 2025
dsavineau
approved these changes
Jan 9, 2025
|
unrelated CI failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api-deployment template does not apply successfully because the resource requirements are being templated in outside of the nginx block in the deployment yaml. It just needs to be moved up a line and it will work.