feat: allow for debug mode execution #1577
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
==========================================
- Coverage 91.61% 91.60% -0.02%
==========================================
Files 86 86
Lines 7064 7067 +3
==========================================
+ Hits 6472 6474 +2
- Misses 592 593 +1 ☔ View full report in Codecov by Sentry. |
|
This PR requieres that windows-latest is also windows-25.2 at least. |
b-matteo
reviewed
Jan 10, 2025
| if enable_debug_features: | ||
| if self.client.backend_version > (25, 1, 0): | ||
| request.script_type = RunScriptType.DEBUG | ||
| else: # pragma: no cover |
There was a problem hiding this comment.
Depending on what Ken tells us about the debug mode, we might need to filter here if we run against DMS.
b-matteo
reviewed
Jan 10, 2025
| # Discovery (.dscript) | ||
| def test_dscript_simple_script_debug_mode(modeler: Modeler): | ||
| # Skip on Linux | ||
| skip_if_linux(modeler, test_dscript_simple_script.__name__, "run_discovery_script_file") |
There was a problem hiding this comment.
Same here, if debug run script won't be available on DMS before it's retired, we'll need to skip that test for DMS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the execution of debug mode in product scripting.
Issue linked
Closes #1576
Checklist
feat: extrude circle to cylinder)