Skip to content

Commit

Permalink
Merge pull request #15 from ant-media/fix/issue-5764
Browse files Browse the repository at this point in the history
No active stream in room callback broke conference
  • Loading branch information
mustafaboleken authored Dec 14, 2023
2 parents b38e7c1 + 3f038bf commit aeeae96
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
9 changes: 7 additions & 2 deletions example/src/conference.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,13 @@ export default function Conference() {
}
},
callbackError: (err: any, data: any) => {
console.error('callbackError', err, data);
clearRoomInfoInterval();
if (err === "no_active_streams_in_room") {
// it throws this error when there is no stream in the room
// so we shouldn't reset streams list
} else {
console.error('callbackError', err, data);
clearRoomInfoInterval();
}
},
peer_connection_config: {
iceServers: [
Expand Down
9 changes: 7 additions & 2 deletions samples/conference/src/conference.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,13 @@ export default function Conference() {
}
},
callbackError: (err: any, data: any) => {
console.error('callbackError', err, data);
clearRoomInfoInterval();
if (err === "no_active_streams_in_room") {
// it throws this error when there is no stream in the room
// so we shouldn't reset streams list
} else {
console.error('callbackError', err, data);
clearRoomInfoInterval();
}
},
peer_connection_config: {
iceServers: [
Expand Down

0 comments on commit aeeae96

Please sign in to comment.