Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow circle settings to be configured through customSettings #424

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

lastpeony
Copy link
Contributor

@lastpeony lastpeony commented Nov 28, 2024

#415

allow circle settings to be configured through customSettings like plugins.

example:

"customSettings":{
"circle":{
"roomCreationPassword":"123123"
}
}

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.09%. Comparing base (c4cc536) to head (50b02c3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   74.09%   74.09%           
=======================================
  Files          67       67           
  Lines        3169     3169           
  Branches      713      713           
=======================================
  Hits         2348     2348           
  Misses        740      740           
  Partials       81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mustafaboleken mustafaboleken linked an issue Jan 8, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use AppSettings for Circle specific settings
2 participants