Metavalue cleanup #378
Merged
Metavalue cleanup #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikey, containers should be updated already. Can you please restart the CI? |
|
@umarcor Nice, seems to be working now. Thanks! |
|
Merged with paulus' big series in #379 and meta values reports are up from 142 to 780 (still better than 63,000), so might need a few more fixes. |
This affects other files which have been included here. Signed-off-by: Michael Neuling <[email protected]>
Signed-off-by: Michael Neuling <[email protected]>
Signed-off-by: Michael Neuling <[email protected]>
Signed-off-by: Michael Neuling <[email protected]>
Signed-off-by: Michael Neuling <[email protected]>
Signed-off-by: Michael Neuling <[email protected]>
Signed-off-by: Michael Neuling <[email protected]>
Signed-off-by: Michael Neuling <[email protected]>
Signed-off-by: Michael Neuling <[email protected]>
Signed-off-by: Michael Neuling <[email protected]>
Signed-off-by: Michael Neuling <[email protected]>
Signed-off-by: Michael Neuling <[email protected]>
|
Rebasing on upsteam to make it easier to review after @paulusmack changes. This update also gets us down to 118 meta values warnings (from 64K) |
Signed-off-by: Michael Neuling <[email protected]>
The following commit added two tests but didn't update the tests
outputs:
commit 73cc516
Author: Paul Mackerras <[email protected]>
Date: Mon May 9 19:18:42 2022 +1000
Use FPU for division instructions if we have an FPU
This patch updates these using tests/update_console_tests
Signed-off-by: Michael Neuling <[email protected]>
Make sure they don't increase in future Signed-off-by: Michael Neuling <[email protected]>
|
Added some tests so we don't increase metavalues over time. Also has a minor fix for the FPU test which wasn't updated to the latest code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #272, microwatt produces lots of metavalue warnings.
This patch series fixes a lot of them. Running hello for 100us now gives a lot less errors:
Master:
Now
This series either propagates the X/U state or causes a fatal error in the sim.
This is ready to go except for the CI regression. This regression is caused by a bug in GHDL synth which is fixed in ghdl/ghdl#2129. We're waiting for the new GHDL docker containers to be build, then CI should pass.