Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gke.md #2302

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Update gke.md #2302

merged 1 commit into from
Sep 27, 2024

Conversation

LeBaronDeCharlus
Copy link

@LeBaronDeCharlus LeBaronDeCharlus commented Sep 26, 2024

Missing apisix key for set variable

Type of change:

  • Documentation

What this PR does / why we need it:

Fixing missing keyword on apisix GKE documentation.

Missing apisix key for set variable
Copy link
Member

@pottekkat pottekkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

Unrelated CI errors can be fixed separately.

@kayx23 kayx23 merged commit dc280b5 into apache:v1.8.0 Sep 27, 2024
26 of 27 checks passed
@kayx23
Copy link
Member

kayx23 commented Sep 27, 2024

Just realized this is merged into 1.8.0. Please make the same update for master as well thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants