Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add override functions for accepting suppliers. #586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XenoAmess
Copy link
Contributor

it be needed as something like:
query several mongo collections one by one, etc.
t is useful, yeah, at lease my job needs it now...

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

@XenoAmess
Copy link
Contributor Author

XenoAmess commented Jan 10, 2025

@garydgregory please have a look and give some opinions.
once you aggree these changes, unit testes would be added...

just like our good old days, sigh.
but I'm no student anymore, and grow too busy to be very active...

@garydgregory
Copy link
Member

garydgregory commented Jan 10, 2025

Hello @XenoAmess

-1: I won't spend time reviewing this new code without unit tests. Instead, I'll spend my time writing this: Tests in PRs are important: They show intent, edge cases, and expected failures. A contributor must show the intended usage of the code, without an application, unit tests stand in for these call sites. Asking a maintainer (me) to spend their time when you did not spend your time doing the basics it not an equitable trade-off.

@XenoAmess
Copy link
Contributor Author

Hello @XenoAmess

-1: I won't spend time reviewing this new code without unit tests. Instead, I'll spend my time writing this: Tests in PRs are important: They show intent, edge cases, and expected failures. A contributor must show the intended usage of the code, without an application, unit tests stand in for these call sites. Asking a maintainer (me) to spend their time when you did not spend your time doing the basics it not an equitable trade-off.

sounds reasonable.
My real situation, for which I need this pr, is for MongoClient produced iterables...
Though import MongoClient into this repo's unit test sounds crazy, I would make a mock one instead, and try to explain my expecting usage using codes.
Please wait for several hours.

it be needed as something like: query several mongo collections one by one, etc.
@XenoAmess XenoAmess changed the title add two override functions for accepting suppliers. add override functions for accepting suppliers. Jan 11, 2025
@XenoAmess XenoAmess force-pushed the feature-add-iterable-utils-suppliers-ovedrload branch from 992c5e0 to 0dbf285 Compare January 11, 2025 12:21
@XenoAmess
Copy link
Contributor Author

XenoAmess commented Jan 11, 2025

@garydgregory unit test added. please have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants