IGNITE-24286 Implement recording sytemViews to perfStart report #11826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chesnokoff
force-pushed
the
ignite-24286
branch
from
4eea0e1 to
05cb868
Compare
AttributeToMapVisitor class can collect data from system views
The method writes data to .prf file
…lect system views
chesnokoff
force-pushed
the
ignite-24286
branch
3 times, most recently
from
d3f8f73 to
32caae6
Compare
chesnokoff
force-pushed
the
ignite-24286
branch
from
32caae6 to
672b625
Compare
timoninmaxim
requested changes
Jan 24, 2025
| if (view != null) | ||
| return view; | ||
|
|
||
| if (view == null) { |
There was a problem hiding this comment.
At this line view is always null.
| * @param viewName System view name. | ||
| * @return System view with viewName. Null if the view does not exist. | ||
| */ | ||
| @Nullable public static SystemView<?> getSystemViewByName(GridSystemViewManager systemViewManager, String viewName) { |
There was a problem hiding this comment.
We don't use prefixes like get, set, is in function names within internal packages
| views = new ArrayList<>(); | ||
| sysViewMgr.forEach(view -> views.add(view.name())); | ||
| } | ||
| else if (startCmdArg.systemViews() != null) views = List.of(startCmdArg.systemViews()); |
There was a problem hiding this comment.
Block of code after condition should be on own line
|
|
||
| if (buf.remaining() < 4) | ||
| return false; | ||
| int attrsNumber = buf.getInt(); |
| @@ -45,6 +47,12 @@ public class PerformanceStatisticsCommandTest extends GridCommandHandlerClusterB | |||
| /** */ | |||
| public static final String STATUS = "status"; | |||
|
|
|||
| /** */ | |||
| public static final String ALL_VIEWS = "--all-system-views"; | |||
There was a problem hiding this comment.
Do we actually need to provide options here? Why just collecting all views is not a default behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.