Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Break point issue of home, from 551px to 695px screen size. #657

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

im-chandraprakash
Copy link

What does this Pull Request do ?

i Fixed Break point issue of home, from 551px to 695px screen size which was breaking earlier but now working good.

Fixes #369

Screenshot 2023-10-13 234812

##Types of change

I modified certain fixed pixel sizes to expand to full width when the screen size is smaller.

@d4x1 d4x1 requested a review from mintsweet October 15, 2023 14:11
@mintsweet
Copy link
Member

Hi @07-Chandra thank you for your pr. Can you remove content about the code format?

@im-chandraprakash
Copy link
Author

im-chandraprakash commented Oct 17, 2023

i'm newbie to the contribution and not able to understand error- "merging is blocked" and about content about the code format . can you please elaborate more ?

@mintsweet
Copy link
Member

Hi, @07-Chandra We are very sorry for the trouble caused to you because our repo does not have a formatting tool. We also don’t want to include unnecessary content in a PR, as shown in the screenshot below. The automatic formatting of your editor may cause it, so can you please remove modifications like this?

image

@im-chandraprakash
Copy link
Author

thank you, i will modify codes and will send new PR

@im-chandraprakash
Copy link
Author

im-chandraprakash commented Oct 17, 2023

i think, now i have solved issues and changed content formation.
please review my new commit Chnages.
if you see still any issue please let me know, i will work on those part.




Expand All
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @07-Chandra, can you check here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@im-chandraprakash
Copy link
Author

please check now

<div
return (
<div className="w-full">
<img
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @07-Chandra, I understand you only modified w-full, but there are still many additional changes in this file, can you remove these? Thank you.

@Startrekzky
Copy link
Contributor

Hi @07-Chandra , can you update the PR so that we can get it merged? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakpoint issue
3 participants