-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #728: Adding asterisk for metadata transfer #1117
Issue #728: Adding asterisk for metadata transfer #1117
Conversation
Signed-off-by: Michael Dinzinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! this would be very helpful. See comments on possible improvements
core/src/main/java/com/digitalpebble/stormcrawler/util/MetadataTransfer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/digitalpebble/stormcrawler/util/MetadataTransfer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Dinzinger <[email protected]>
That's fab, thanks @michaeldinzinger! I think the change would affect both the metadata to transfer and the metadata to persist, in which case ideally we would like to have a test demonstrating the impact on the latter. We'd also need to make it explicit in the default config as well as the configs generated by the archetypes. |
…persist + transfer Signed-off-by: Michael Dinzinger <[email protected]>
Thank you again for your quick reply.
How could such a demonstration test look like? For now, I extended the method
I added a comment line in each of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks a lot @michaeldinzinger, this is a great addition to StormCrawler
Hello all
Goal:
When having a lot of metadata fields that all start with the same prefix, e.g.
parse.[...]
, one can simply writeinstead of listing them all.
Besides that, making mdToTransfer, mdToPersistOnly, trackPath and trackDepth protected instead of private. This makes it easier to create a Custom Metadata Transfer class.