Only enable support for tests.profile if jdk.jfr module is available in Gradle runtime #12845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Gradle runtime (otherwise buildSrc compilation fails)
dweiss
approved these changes
Nov 25, 2023
| if (!rootProject.hasJavaFlightRecorder) { | ||
| logger.warn('Module jdk.jfr is not available; skipping compilation of Java Flight Recorder support.') | ||
| tasks.named('compileJava').configure { | ||
| exclude('**/ProfileResults.java') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use OpenJ9 JDKs to run Gradle and Tests, the compilation of
buildSrcfails, due to Java Flight recorder not being available in the Gradle runtime.This PR fixes this by excluding the Profile code from compilation and also throwing an exception if you enable
-Ptests.profile=true.I tested this with OpenJ9 and Hotspot. On Jenkins we do not see that problem, because we always run Gradle with a Hotspot JDK and only enable OpenJ9 as runtime.
This issue also affects the OpenJ9 team when they try to reproduce bugs with OpenJ9 VM: eclipse-openj9/openj9#18400