Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes when built with exotic headers #1950

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

chrysn
Copy link
Contributor

@chrysn chrysn commented Dec 28, 2024

Updating RIOT OS from Nimble 1.5.0 to 1.8.0, I found that some assumptions were made on header contents that are not backed by the specs:

  • In a file using vnprintf, stdio.h was not included.
  • In several files, a min() function was used without being defined -- presumably it is defined in some variations of the included headers, but not in one where it would be guaranteed.

The patches in this PR fix this; the implementation of min() was already present in several of the compilation units using the function, but not in all of them.

@sjanc sjanc merged commit cf947cd into apache:master Jan 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants