[ISSUE #8895] CreateFlushConsumeQueueService for loadAndStartConsumerServiceOnly #9094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9094 +/- ##
=============================================
- Coverage 48.00% 47.97% -0.04%
+ Complexity 12049 12037 -12
=============================================
Files 1320 1320
Lines 92782 92783 +1
Branches 11897 11897
=============================================
- Hits 44544 44510 -34
- Misses 42733 42760 +27
- Partials 5505 5513 +8 ☔ View full report in Codecov by Sentry. |
lizhimins
reviewed
Jan 6, 2025
| @@ -381,6 +381,7 @@ public synchronized boolean start() { | |||
| public synchronized boolean shutdown() { | |||
| try { | |||
| if (!this.loaded) { | |||
| LOGGER.info("shutdown OK. {} is not loaded", this.dbPath); | |||
There was a problem hiding this comment.
The log content should be more specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8895
Brief Description
How Did You Test This Change?