The lite-core module decouples ZooKeeper #2182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2182 +/- ##
=========================================
Coverage 84.61% 84.61%
- Complexity 1916 1917 +1
=========================================
Files 286 287 +1
Lines 6279 6279
Branches 695 692 -3
=========================================
Hits 5313 5313
- Misses 646 648 +2
+ Partials 320 318 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Please take a look @TeslaCN |
TeslaCN
requested changes
Mar 15, 2023
| @@ -17,9 +17,14 @@ | |||
|
|
|||
| package org.apache.shardingsphere.elasticjob.lite.api.registry; | |||
|
|
|||
| import java.util.Arrays; | |||
There was a problem hiding this comment.
There are too many unrelated changes in this PR. Please revert them.
There was a problem hiding this comment.
Caused by reformatting code.
| <groupId>org.apache.shardingsphere.elasticjob</groupId> | ||
| <artifactId>elasticjob-registry-center-zookeeper-curator</artifactId> | ||
| <version>${project.parent.version}</version> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
Could we consider setting it runtime? Otherwise users need to introduce it sperately.
There was a problem hiding this comment.
Yes, after decoupling, users are expected to actively introduce.
There was a problem hiding this comment.
- @mytang0 Do you still have time to update the current PR? Maybe allow another person to raise a new PR fixing the current one? I just noticed please remove zookeeper dependent #2400 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2183 .
Changes proposed in this pull request:
The elasticjob-lite-core module decouples ZooKeeper, introduce the implementation of the on-demand registration center when using it.