Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4169: Decouple from Hadoop's jackson version and shade the latest… #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abstractdog
Copy link
Contributor

… in Tez

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 33m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 6m 47s Maven dependency ordering for branch
+1 💚 mvninstall 10m 19s master passed
+1 💚 compile 9m 46s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 compile 9m 14s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 javadoc 9m 10s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 8m 32s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
_ Patch Compile Tests _
+0 🆗 mvndep 0m 37s Maven dependency ordering for patch
+1 💚 mvninstall 7m 45s the patch passed
+1 💚 compile 9m 36s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javac 9m 36s the patch passed
+1 💚 compile 9m 16s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 javac 9m 16s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 14s The patch has no ill-formed XML file.
+1 💚 javadoc 8m 56s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 8m 15s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
_ Other Tests _
+1 💚 unit 2m 43s tez-api in the patch passed.
+1 💚 unit 1m 44s tez-mapreduce in the patch passed.
+1 💚 unit 42m 2s tez-tests in the patch passed.
+1 💚 unit 4m 36s tez-ext-service-tests in the patch passed.
+1 💚 unit 0m 50s tez-protobuf-history-plugin in the patch passed.
+1 💚 unit 2m 2s tez-yarn-timeline-history in the patch passed.
+1 💚 unit 2m 12s tez-yarn-timeline-history-with-acls in the patch passed.
+1 💚 unit 2m 0s tez-yarn-timeline-history-with-fs in the patch passed.
+1 💚 unit 2m 50s tez-history-parser in the patch passed.
+1 💚 unit 3m 16s job-analyzer in the patch passed.
-1 ❌ unit 10m 27s root in the patch failed.
+1 💚 asflicense 7m 27s The patch does not generate ASF License warnings.
216m 10s
Reason Tests
Failed junit tests tez.runtime.library.common.shuffle.TestShuffleUtils
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-247/1/artifact/out/Dockerfile
GITHUB PR #247
JIRA Issue TEZ-4169
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 0529c162af78 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 8ebc4b0
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-247/1/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-247/1/testReport/
Max. process+thread count 1755 (vs. ulimit of 5500)
modules C: tez-api tez-mapreduce tez-tests tez-ext-service-tests tez-plugins/tez-protobuf-history-plugin tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-history-with-acls tez-plugins/tez-yarn-timeline-history-with-fs tez-plugins/tez-history-parser tez-tools/analyzers/job-analyzer . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-247/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn
Copy link
Member

ayushtkn commented May 4, 2023

The latest hadoop code has higher jackson version.
https://github.com/apache/hadoop/blob/trunk/hadoop-project/pom.xml#L71-L73
btw. jackson & jersey are bit messy, is the reason behind shading was older version from hadoop, and we wanted to move forward?

Well, jackson in hadoop code does seems to be used in hdfs-client, and in RBF(hdfs federation), maven classpaths during tests and in the actual differ in some cases, not sure how safe it is, if there is any interaction b/w any Hadoop method which takes any jackson class as an argument, it would create noise, typical problems, with shading.....

if only version is an issue, hadoop 3.3.5 is out and I am attempting an upgrade to that and it has 2.12 jackson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants