feat: use checker.name to format periodic lock to distribute active check task to multiple workers #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using a constant as
self.PERIODIC_LOCK
causes all active health tasks to be processed by only one worker. Even if other workers receive a request associated with another checker, they cannot start the health check actually. ref:lua-resty-healthcheck/lib/resty/healthcheck.lua
Lines 1214 to 1235 in 09a672e
lua-resty-healthcheck/lib/resty/healthcheck.lua
Lines 1726 to 1741 in 09a672e
lua-resty-healthcheck/lib/resty/healthcheck.lua
Line 1671 in 09a672e