Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more details about different ProxyConfiguration options #2793

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Jan 6, 2025

Adds separate sections for each ProxyConfiguration option and explains when to use which.

Related to #2778

@barjin barjin self-assigned this Jan 6, 2025
@github-actions github-actions bot added this to the 105th sprint - Tooling team milestone Jan 6, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jan 6, 2025
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Jan 7, 2025
@barjin barjin marked this pull request as ready for review January 7, 2025 12:54
@B4nan B4nan requested review from B4nan and janbuchar January 13, 2025 13:24
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nits. also lets port the changes to latest docs snapshot

docs/guides/proxy_management.mdx Outdated Show resolved Hide resolved
docs/guides/proxy_management.mdx Outdated Show resolved Hide resolved
docs/guides/proxy_management.mdx Outdated Show resolved Hide resolved
docs/guides/proxy_management.mdx Outdated Show resolved Hide resolved
docs/guides/proxy_management.mdx Outdated Show resolved Hide resolved
docs/guides/proxy_management.mdx Outdated Show resolved Hide resolved
@barjin
Copy link
Contributor Author

barjin commented Jan 17, 2025

There's no harm in merging docs updates even with the broken CI, right?

@B4nan
Copy link
Member

B4nan commented Jan 17, 2025

Yeah it's fine, but we really need to fix the CI so we can release things 🙃

@barjin barjin merged commit 8dc3368 into master Jan 17, 2025
5 of 9 checks passed
@barjin barjin deleted the docs/tiered-proxies branch January 17, 2025 15:35
@barjin barjin mentioned this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants