Base branch for JSONSelection::compute_output_shape and URI type checking
#6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # apollo-federation/src/sources/connect/expand/mod.rs # apollo-federation/src/sources/connect/expand/tests/snapshots/[email protected] # apollo-federation/src/sources/connect/header.rs # apollo-federation/src/sources/connect/models.rs # apollo-federation/src/sources/connect/url_template.rs # apollo-federation/src/sources/connect/validation/graphql/strings.rs # apollo-federation/src/sources/connect/validation/snapshots/validation_tests@keys_and_entities__invalid__arg_is_object_but_field_is_not.graphql.snap # apollo-federation/src/sources/connect/variable.rs
# Conflicts: # apollo-router/src/plugins/connectors/http_json_transport.rs
# Conflicts: # apollo-federation/src/sources/connect/header.rs # apollo-federation/src/sources/connect/variable.rs # apollo-router/src/plugins/connectors/http_json_transport.rs
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 4c2da5ec0064d35ec3a66592 |
dylan-apollo
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects several commits (including merges with
next) that originally appeared at the beginning of the history for PR #6513, before any of the commits from #6458. I've split this history into its own PR to keep both of those other PRs tidier.