feat: add screenState=SCREEN_STATE_OFF as the screen locked #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/unit/helper-specs.js
Outdated
| mCurrentUserId=0 | ||
| ... | ||
| `; | ||
| (await isScreenStateOff(dumpsys)).should.be.false; |
There was a problem hiding this comment.
this method should not be awaited
mykola-mokhnach
approved these changes
Jan 24, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
## [12.12.0](v12.11.0...v12.12.0) (2025-01-24) ### Features * add screenState=SCREEN_STATE_OFF as the screen locked ([#791](#791)) ([6f6f45a](6f6f45a))
|
🎉 This PR is included in version 12.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support appium/appium-uiautomator2-driver#859 case.
I confirmed that the current method to detect the lock screen didn't work in the issue's use case. Actually, when the device screen was off while screen recording was working, the existing one didn't match as "locked."
screenState=SCREEN_STATE_OFFcould help in this case.This doesn't change current behavior when no screen recording is working, so this could be "fix" I think but this adds a new flag to detect the state so I made this as a "feat."