Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not run version vector with encryption-at-rest feature. #11646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

do not run version vector with encryption-at-rest feature. #11646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions fdbserver/CommitProxyServer.actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,11 @@ inline bool shouldBackup(MutationRef const& m) {
std::set<Tag> CommitBatchContext::getWrittenTagsPreResolution() {
std::set<Tag> transactionTags;
std::vector<Tag> cacheVector = { cacheTag };
// version vector is an experimental feature that does not support encryption at rest or backup.
// This is indicated by returning an empty set of tags from this function.
if (pProxyCommitData->encryptMode.isEncryptionEnabled()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that the version vector won't get updated with the tags of these mutations or the mutations get sent to all logs?

Copy link
Contributor Author

@dlambrig dlambrig Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It ends up being the same behavior as a private transaction. The mutations get sent to all logs, and every tlog is included in the tpcv data structure. I am not sure writtenTags is updated with all SS, though (and therefore the vv), so will investigate that and follow up.

return std::set<Tag>();
}
for (int transactionNum = 0; transactionNum < trs.size(); transactionNum++) {
int mutationNum = 0;
VectorRef<MutationRef>* pMutations = &trs[transactionNum].transaction.mutations;
Expand Down