-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend gray failure recentHealthTriggeredRecoveryTime to reflect any recovery trigger #11877
Draft
spraza
wants to merge
2
commits into
apple:main
Choose a base branch
from
spraza:gray-failure-include-all-recoveries
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t any recovery, including non-gray failure triggered ones
spraza
changed the title
Extend gray failure recentHealthTriggeredRecoveryTime state to reflect any recovery
Extend gray failure recentHealthTriggeredRecoveryTime to reflect any recovery trigger
Jan 11, 2025
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend gray failure recentHealthTriggeredRecoveryTime state to reflect any recovery, including non-gray failure triggered ones. This helps reduce number of false positive gray failure recoveries.
Let's take an example.
CC_MAX_HEALTH_RECOVERY_COUNT
is 1 andCC_TRACKING_HEALTH_RECOVERY_INTERVAL
is 120.Previously, gray failure will trigger another recovery after a non-gray failure recovery regardless of the knob values above.
Now, the knobs account for non-gray failure recoveries as well. So in this example, gray failure will not trigger another recovery after non-gray failure recovery for atleast 2 minutes. After 2 minutes, if complaints have not expired and workers have not recovered, gray failure can decide to trigger a recovery.
Once accepted, will also create a backport PR for 7.3.
Testing
20250111-000712-praza-5160fe051c0f2a507d0339b79b934665fb5403 compressed=True data_size=36362848 fail_fast=10 max_runs=100000 priority=100 sanity=False submitted=20250111-000712 timeout=5400 username=praza-5160fe051c0f2a507d0339b79b934665fb54030e
. Will update results when done.fdbserver -r unittests -f /fdbserver/clustercontroller/
which includes gray failure unit tests, all pass.Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)