Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #52; Improved code style in config.json #53

Closed
wants to merge 0 commits into from

Conversation

PatrickR315516
Copy link
Contributor

As mentioned in #52.

Copy link
Contributor

@karulont karulont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick about naming, otherwise looks good.

Sources/PIRService/ReloadService.swift Outdated Show resolved Hide resolved
@karulont
Copy link
Contributor

Please see https://github.com/apple/live-caller-id-lookup-example?tab=readme-ov-file#contributing

Automatic checks failed.
The obvious issue is that "usergroup" was renamed to "userGroup" only partially.
But the other issue seems to be some trailing whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants