Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a small error in AlgorithmIdentifier description and add missing cases #222

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix a small error in AlgorithmIdentifier description and add missing cases #222

merged 1 commit into from
Jan 20, 2025

Conversation

baarde
Copy link
Contributor

@baarde baarde commented Jan 19, 2025

This PR adds missing cases and fixes a small typo.

I haven't added tests, as AlgorithmIdentifier is internal API.

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Jan 20, 2025
@Lukasa Lukasa merged commit 41066b1 into apple:main Jan 20, 2025
37 checks passed
@Lukasa
Copy link
Contributor

Lukasa commented Jan 20, 2025

Thanks a bunch!

@baarde baarde deleted the fix-algorithm-id-desc branch January 20, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baarde @Lukasa