Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix amd64 support #223

Merged
merged 3 commits into from
Jan 24, 2025
Merged

fix amd64 support #223

merged 3 commits into from
Jan 24, 2025

Conversation

michael-yuji
Copy link
Member

Fix when "${CMAKE_SYSTEM_PROCESSOR}" is lowercase "amd64"

dnadoba
dnadoba approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@dnadoba dnadoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable as we do it above for ARM64 as well.

@dnadoba dnadoba added the 🔨 semver/patch No public API change. label Jan 24, 2025
@dnadoba
Copy link
Member

dnadoba commented Jan 24, 2025

Benchmarks for nightly 6.1 fails because of

Could not find any matching absolute thresholds at path [Benchmarks/Thresholds/nightly-6.1/], failing threshold check.

this is unrelated to this PR. Merging over the failure.

@dnadoba dnadoba merged commit b32a9ba into apple:main Jan 24, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnadoba dnadoba dnadoba approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-yuji @dnadoba