Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .github/workflows/build.yml #32

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Add .github/workflows/build.yml #32

merged 1 commit into from
Dec 16, 2024

Conversation

kubamracek
Copy link
Collaborator

No description provided.

@kubamracek kubamracek force-pushed the gh-actions branch 5 times, most recently from 6db80df to d6800f1 Compare December 12, 2024 19:23
@kubamracek kubamracek force-pushed the gh-actions branch 5 times, most recently from 51d633b to 0e50599 Compare December 13, 2024 19:37
@kubamracek
Copy link
Collaborator Author

kubamracek commented Dec 14, 2024

Just updated the CI setup to use the latest (Dec 13) official swift.org "main" nightly toolchain, which has the two C++ interop fixes that were blocking the build (swiftlang/swift#78100, swiftlang/swift#78147). The CI is green, the build passes now 🥳

Resolves a bunch reported issues:

Copy link
Collaborator

@rauhul rauhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give this a nice commit message when merging!

@@ -38,6 +38,8 @@
//
// connectedhomeip/src/credentials/FabricTable.h:82:69: error: use of undeclared identifier 'strnlen'
extern "C" size_t strnlen(const char *s, size_t maxlen);
// esp-matter/components/esp_matter/esp_matter_client.h:57:26: error: use of undeclared identifier 'strdup'
extern "C" char *strdup(const char *s1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to do this instead of #include <string.h>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't spend time investigating why, but #include <string.h> didn't resolve the problem.

@kubamracek kubamracek merged commit 0cf0959 into main Dec 16, 2024
13 checks passed
@kubamracek kubamracek deleted the gh-actions branch December 16, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants