[move] Change copybara to sync with move-on-aptos #15458
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 17m total CI duration on this PR
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
georgemitenkov
requested review from
vgao1996,
wrwg,
rahxephon89,
brmataptos and
sausagee
georgemitenkov
commented
Dec 3, 2024
| @@ -55,7 +55,7 @@ core.workflow( | |||
| ), | |||
| destination = git.github_destination( | |||
| url = moveUrl, | |||
| push = "aptos-main", | |||
| push = "main", | |||
There was a problem hiding this comment.
Note: this flow does not work anymore, because main is protected. Should we just remove it? cc @wrwg
There was a problem hiding this comment.
Might need to tweak the repo config here. In the future we'll likely need set up a bot for this.
There was a problem hiding this comment.
Yes, we probably need an automation to sync e.g. nightly etc. PRs are nicer though because if there are crate dependencies, these do not automatically sync with copybara
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets correct URLs, branches to sync
third-party/movewithmove-on-aptos.How Has This Been Tested?
Created a PR in
move-on-aptoswith recent changes: move-language/move-on-aptos#3Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist