[move-vm][closures] Refactor: move abilities and closure mask into core types #15668

wrwg · 2025-01-04T22:27:48Z

Description

[PR 2/n vm closures]

The type AbilitySet is required in MoveTypeLayout, and the type ClosureMask in MoveValue. This PRs moves those both types from file_format into the core types crate.

How Has This Been Tested?

Existing tests

Type of Change

Which Components or Systems Does This Change Impact?

trunk-io · 2025-01-04T22:27:51Z

⏱️ 58m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
rust-move-tests	13m	🟩
rust-move-tests	13m	🟩
rust-move-tests	8m	🟥
rust-cargo-deny	7m	🟩 🟩 🟩 🟩
cli-e2e-tests / run-cli-tests	7m	🟩
check-dynamic-deps	3m	🟩 🟩 🟩 🟩
rust-move-tests	2m	🟥
general-lints	2m	🟩 🟩 🟩 🟩
fetch-last-released-docker-image-tag	2m	🟩
semgrep/ci	1m	🟩 🟩 🟩 🟩
file_change_determinator	46s	🟩 🟩 🟩 🟩
permission-check	12s	🟩 🟩 🟩 🟩
permission-check	12s	🟩 🟩 🟩 🟩
file_change_determinator	10s	🟩
determine-docker-build-metadata	1s	🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

wrwg · 2025-01-04T22:28:06Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

third_party/move/move-vm/types/src/values/values_impl.rs

third_party/move/move-compiler-v2/src/pipeline/ability_processor.rs

third_party/move/move-ir-compiler/move-bytecode-source-map/src/source_map.rs

third_party/move/move-core/types/src/ability.rs

third_party/move/move-binary-format/src/binary_views.rs

third_party/move/move-vm/types/src/loaded_data/runtime_types.rs

third_party/move/move-core/types/src/function.rs

…re types [PR 2/n vm closures] The type `AbilitySet` is required in `MoveTypeLayout`, and the type `ClosureMask` in `MoveValue`. This PRs moves those both types from file_format into the core types crate.

github-actions · 2025-01-25T04:49:12Z

✅ Forge suite `compat` success on `cb5d7c9615b937357dbede9439401be640fb7d17` ==> `76701d87f547e8c7a118b95e3248e75994e36fcb`

Compatibility test results for cb5d7c9615b937357dbede9439401be640fb7d17 ==> 76701d87f547e8c7a118b95e3248e75994e36fcb (PR)
1. Check liveness of validators at old version: cb5d7c9615b937357dbede9439401be640fb7d17
compatibility::simple-validator-upgrade::liveness-check : committed: 12634.12 txn/s, latency: 2516.65 ms, (p50: 2600 ms, p70: 2700, p90: 2900 ms, p99: 4000 ms), latency samples: 410720
2. Upgrading first Validator to new version: 76701d87f547e8c7a118b95e3248e75994e36fcb
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4565.50 txn/s, latency: 6711.51 ms, (p50: 6500 ms, p70: 8500, p90: 8700 ms, p99: 8800 ms), latency samples: 91200
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4445.91 txn/s, latency: 7635.17 ms, (p50: 8600 ms, p70: 8700, p90: 9000 ms, p99: 9000 ms), latency samples: 157180
3. Upgrading rest of first batch to new version: 76701d87f547e8c7a118b95e3248e75994e36fcb
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4301.75 txn/s, latency: 7246.86 ms, (p50: 8000 ms, p70: 8700, p90: 9100 ms, p99: 9100 ms), latency samples: 91900
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4324.43 txn/s, latency: 7859.60 ms, (p50: 8800 ms, p70: 8900, p90: 9100 ms, p99: 9200 ms), latency samples: 152980
4. upgrading second batch to new version: 76701d87f547e8c7a118b95e3248e75994e36fcb
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8126.61 txn/s, latency: 3786.30 ms, (p50: 4400 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 149960
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8063.16 txn/s, latency: 4258.97 ms, (p50: 4600 ms, p70: 4700, p90: 4900 ms, p99: 5100 ms), latency samples: 270100
5. check swarm health
Compatibility test for cb5d7c9615b937357dbede9439401be640fb7d17 ==> 76701d87f547e8c7a118b95e3248e75994e36fcb passed
Test Ok

github-actions · 2025-01-25T04:49:55Z

✅ Forge suite `realistic_env_max_load` success on `76701d87f547e8c7a118b95e3248e75994e36fcb`

two traffics test: inner traffic : committed: 14810.85 txn/s, latency: 2675.23 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3300 ms), latency samples: 5631420
two traffics test : committed: 99.96 txn/s, latency: 1520.76 ms, (p50: 1400 ms, p70: 1500, p90: 2000 ms, p99: 3100 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.613, avg: 1.362", "ConsensusProposalToOrdered: max: 0.310, avg: 0.292", "ConsensusOrderedToCommit: max: 0.414, avg: 0.395", "ConsensusProposalToCommit: max: 0.705, avg: 0.687"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.67s no progress at version 32136 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.66s no progress at version 2674880 (avg 0.66s) [limit 16].
Test Ok

wrwg mentioned this pull request Jan 4, 2025

[move-vm][closures] Types and opcodes for closures #15667

Merged

16 tasks

This was referenced Jan 4, 2025

[move-cm][closures] Refactor: Move type conversions out of Loader into a trait #15669

Merged

[move-vm][closures] Type and Value representation and serialization #15670

Open

wrwg force-pushed the wrwg/clos_file_format branch from e45e16d to f92e339 Compare January 5, 2025 05:50

wrwg force-pushed the wrwg/clos_ability_move branch from 34517a1 to 7862e77 Compare January 5, 2025 05:50

wrwg force-pushed the wrwg/clos_file_format branch 2 times, most recently from 1a207d1 to 9688bde Compare January 5, 2025 23:12

wrwg force-pushed the wrwg/clos_ability_move branch from 7862e77 to ee49138 Compare January 5, 2025 23:50

wrwg force-pushed the wrwg/clos_file_format branch from 9688bde to f2effc9 Compare January 6, 2025 02:47

wrwg force-pushed the wrwg/clos_ability_move branch from ee49138 to 9fbe74f Compare January 6, 2025 02:47

wrwg mentioned this pull request Jan 7, 2025

[move-vm][closures] Interpreter #15680

Open

16 tasks

wrwg requested review from georgemitenkov, runtian-zhou, vgao1996, vineethk and ziaptos January 8, 2025 06:16

wrwg marked this pull request as ready for review January 8, 2025 06:17

wrwg requested review from davidiw, movekevin, banool, gregnazario and 0xmaayan as code owners January 8, 2025 06:17

georgemitenkov reviewed Jan 8, 2025

View reviewed changes

wrwg force-pushed the wrwg/clos_file_format branch from f2effc9 to 3c767c3 Compare January 13, 2025 07:08

wrwg force-pushed the wrwg/clos_ability_move branch 2 times, most recently from a79fde9 to 719f728 Compare January 14, 2025 02:32

wrwg force-pushed the wrwg/clos_file_format branch from 3c767c3 to 0aa8d5d Compare January 16, 2025 06:43

wrwg force-pushed the wrwg/clos_ability_move branch from 719f728 to 41d027e Compare January 16, 2025 06:43

wrwg force-pushed the wrwg/clos_ability_move branch from 8140006 to 40f54be Compare January 21, 2025 16:56

wrwg force-pushed the wrwg/clos_file_format branch from 58fb6ba to 55a5551 Compare January 22, 2025 03:19

wrwg force-pushed the wrwg/clos_ability_move branch from 40f54be to 691dc6e Compare January 22, 2025 03:19

wrwg force-pushed the wrwg/clos_file_format branch from 55a5551 to ffc2f2d Compare January 22, 2025 06:23

wrwg force-pushed the wrwg/clos_ability_move branch from 691dc6e to 14e0465 Compare January 22, 2025 06:23

wrwg force-pushed the wrwg/clos_file_format branch from ffc2f2d to 781423d Compare January 22, 2025 06:52

wrwg force-pushed the wrwg/clos_ability_move branch from 14e0465 to 75db034 Compare January 22, 2025 06:52

runtian-zhou approved these changes Jan 22, 2025

View reviewed changes

wrwg force-pushed the wrwg/clos_file_format branch from 781423d to c9c8a92 Compare January 23, 2025 03:58

wrwg force-pushed the wrwg/clos_ability_move branch 3 times, most recently from cb81217 to 86223e7 Compare January 24, 2025 06:03

wrwg force-pushed the wrwg/clos_file_format branch from 3b278ba to 171ee27 Compare January 25, 2025 01:06

wrwg force-pushed the wrwg/clos_ability_move branch from 86223e7 to 41d50fa Compare January 25, 2025 01:06

Base automatically changed from wrwg/clos_file_format to main January 25, 2025 02:47

wrwg added 2 commits January 24, 2025 18:55

[move-vm][closures] Refactor: move abilities and closure mask into co…

56f8b44

…re types [PR 2/n vm closures] The type `AbilitySet` is required in `MoveTypeLayout`, and the type `ClosureMask` in `MoveValue`. This PRs moves those both types from file_format into the core types crate.

Document ClosureMask::MAX_ARGUMENTS

76701d8

wrwg force-pushed the wrwg/clos_ability_move branch from 41d50fa to 76701d8 Compare January 25, 2025 02:56

wrwg enabled auto-merge (squash) January 25, 2025 03:48

This comment has been minimized.

Sign in to view

wrwg merged commit 84909ca into main Jan 25, 2025
85 of 88 checks passed

wrwg deleted the wrwg/clos_ability_move branch January 25, 2025 04:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[move-vm][closures] Refactor: move abilities and closure mask into core types #15668

[move-vm][closures] Refactor: move abilities and closure mask into core types #15668

wrwg commented Jan 4, 2025

trunk-io bot commented Jan 4, 2025 •

edited

Loading

wrwg commented Jan 4, 2025 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 25, 2025

github-actions bot commented Jan 25, 2025

[move-vm][closures] Refactor: move abilities and closure mask into core types #15668

[move-vm][closures] Refactor: move abilities and closure mask into core types #15668

Conversation

wrwg commented Jan 4, 2025

Description

How Has This Been Tested?

Type of Change

Which Components or Systems Does This Change Impact?

trunk-io bot commented Jan 4, 2025 • edited Loading

wrwg commented Jan 4, 2025 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 25, 2025

✅ Forge suite compat success on cb5d7c9615b937357dbede9439401be640fb7d17 ==> 76701d87f547e8c7a118b95e3248e75994e36fcb

github-actions bot commented Jan 25, 2025

✅ Forge suite realistic_env_max_load success on 76701d87f547e8c7a118b95e3248e75994e36fcb

trunk-io bot commented Jan 4, 2025 •

edited

Loading

wrwg commented Jan 4, 2025 •

edited

Loading

✅ Forge suite `compat` success on `cb5d7c9615b937357dbede9439401be640fb7d17` ==> `76701d87f547e8c7a118b95e3248e75994e36fcb`

✅ Forge suite `realistic_env_max_load` success on `76701d87f547e8c7a118b95e3248e75994e36fcb`