Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): Handle relative directories for modules #3944

Closed
wants to merge 1 commit into from
Closed

fix(misconf): Handle relative directories for modules #3944

wants to merge 1 commit into from

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Mar 31, 2023

Description

Currently, if a terraform deployment contains modules that are defined with relative file paths, trivy silently ignores them and does not scan them.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7
fix(misconf): Handle relative directories for modules
49f1f1d 
Currently, if a terraform deployment contains modules
that are defined with relative file paths, trivy silently
ignores them and does not scan them.

Signed-off-by: Simar <[email protected]>
@simar7 simar7 force-pushed the fix-relative-filepaths branch from a278427 to 49f1f1d Compare April 1, 2023 00:25
@simar7
Copy link
Member Author

simar7 commented Apr 5, 2023

Closing in favour of #3991

@simar7 simar7 closed this Apr 5, 2023
@knqyf263 knqyf263 deleted the fix-relative-filepaths branch June 22, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin Awaiting requested review from nikpivkin nikpivkin will be requested when the pull request is marked ready for review nikpivkin is a code owner

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 will be requested when the pull request is marked ready for review knqyf263 is a code owner

@DmitriyLewen DmitriyLewen Awaiting requested review from DmitriyLewen DmitriyLewen will be requested when the pull request is marked ready for review DmitriyLewen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trivy config on terraform skips local modules
1 participant
@simar7