-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow root break for mapfs #4094
Conversation
I confirmed #4090 and this PR help relative paths.
|
This is cool and the correct functionality but I'm curious as I wasn't able to get it run locally. I cherry picked the commits from this PR onto the #4090 PR and ran locally but wasn't able to see the parent issues. /Users/simar/repos/trivy/trivy --debug config /Users/simar/repos/defsec-issues/3575/terraform-module-sample/root
2023-04-20T18:11:28.373-0700 DEBUG Severities: ["UNKNOWN" "LOW" "MEDIUM" "HIGH" "CRITICAL"]
2023-04-20T18:11:28.425-0700 DEBUG cache dir: /Users/simar/Library/Caches/trivy
2023-04-20T18:11:28.425-0700 INFO Misconfiguration scanning is enabled
2023-04-20T18:11:28.426-0700 DEBUG Policies successfully loaded from disk
2023-04-20T18:11:28.457-0700 DEBUG Walk the file tree rooted at '/Users/simar/repos/defsec-issues/3575/terraform-module-sample/root' in parallel
2023-04-20T18:11:29.286-0700 DEBUG OS is not detected.
2023-04-20T18:11:29.286-0700 INFO Detected config files: 2
2023-04-20T18:11:29.286-0700 DEBUG Scanned config file: .
2023-04-20T18:11:29.286-0700 DEBUG Scanned config file: child_modules/child_sqs/main.tf
child_modules/child_sqs/main.tf (terraform)
Tests: 2 (SUCCESSES: 1, FAILURES: 1, EXCEPTIONS: 0)
Failures: 1 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 1, CRITICAL: 0)
HIGH: Queue is not encrypted
═══════════════════════════════════════════════════════════════════════════════════════════════
Queues should be encrypted to protect queue contents.
See https://avd.aquasec.com/misconfig/avd-aws-0096
───────────────────────────────────────────────────────────────────────────────────────────────
child_modules/child_sqs/main.tf:1-7
───────────────────────────────────────────────────────────────────────────────────────────────
1 ┌ resource "aws_sqs_queue" "child_queue" {
2 │ name = "child_queue"
3 │ delay_seconds = 90
4 │ max_message_size = 2048
5 │ message_retention_seconds = 86400
6 │ receive_wait_time_seconds = 10
7 └ }
───────────────────────────────────────────────────────────────────────────────────────────────
Did I miss doing something? |
I think you have missed this change. I've merged the main branch and added the above change. Can you try it again? |
Ah that might have been it. I can confirm it works now. |
Description
In some cases, filesystem scanning needs to access outside of the specified directory.
See this comment.
Related issues
Related PRs
Checklist