Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix the check-errors by updating libwebkit2gtk #1004

Merged
merged 1 commit into from
Jan 10, 2025
Merged

ci: fix the check-errors by updating libwebkit2gtk #1004

merged 1 commit into from
Jan 10, 2025

Conversation

dido18
Copy link
Contributor

@dido18 dido18 commented Jan 10, 2025 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?
    The check-errors was failing with this error:
Reading state information...
E: Unable to locate package libwebkit2gtk-4.0-dev
E: Couldn't find any package by glob 'libwebkit2gtk-4.0-dev'

This may be due to the fact the ubuntu:latest is using ubuntu24.0 starting from 5th Dec 2024. actions/runner-images#10636

Use the libwebkit2gtk-4.1-0 instead of libwebkit2gtk-4.0-dev

  • What is the current behavior?
  • What is the new behavior?
  • Does this PR introduce a breaking change?
  • Other information:

@dido18 dido18 marked this pull request as ready for review January 10, 2025 13:45
@dido18 dido18 requested a review from a team January 10, 2025 13:45
alessio-perugini
alessio-perugini approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dido18 dido18 merged commit 2cb53d3 into main Jan 10, 2025
33 checks passed
@dido18 dido18 deleted the dido18/actions-fix-libwebkit2gtk-version branch January 10, 2025 13:50
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-perugini alessio-perugini alessio-perugini approved these changes

Assignees
No one assigned
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dido18 @alessio-perugini @per1234