-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix agent not able to install esptool
after 1.6.0
#986
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
- Coverage 20.04% 20.01% -0.04%
==========================================
Files 42 42
Lines 2569 2568 -1
==========================================
- Hits 515 514 -1
Misses 1968 1968
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: MatteoPologruto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local tests are OK. The problematic esptool
package installation works and if it was previously broken, a new install request will fix it.
Please check if the PR fulfills these requirements
before creating one)
bug fix
The agent is not able to intall
esptool
after 1.6.0 (more details in #980)The old behavior is restored
No