Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agent not able to install esptool after 1.6.0 #986

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Aug 5, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

bug fix

  • What is the current behavior?

The agent is not able to intall esptool after 1.6.0 (more details in #980)

  • What is the new behavior?

The old behavior is restored

  • Does this PR introduce a breaking change?
  • Other information:

No

@umbynos umbynos added os: linux Specific to Linux operating system os: macos Specific to macOS operating system type: imperfection Perceived defect in any part of project labels Aug 5, 2024
@umbynos umbynos self-assigned this Aug 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.01%. Comparing base (46fbb34) to head (d27b9b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
- Coverage   20.04%   20.01%   -0.04%     
==========================================
  Files          42       42              
  Lines        2569     2568       -1     
==========================================
- Hits          515      514       -1     
  Misses       1968     1968              
  Partials       86       86              
Flag Coverage Δ
unit 20.01% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xayton Xayton added this to the 1.6.1 milestone Aug 5, 2024
@umbynos umbynos linked an issue Aug 5, 2024 that may be closed by this pull request
3 tasks
@Xayton Xayton removed this from the 1.6.1 milestone Aug 5, 2024
@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Aug 5, 2024
Co-authored-by: MatteoPologruto <[email protected]>
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work 🚀

Copy link
Contributor

@Xayton Xayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local tests are OK. The problematic esptool package installation works and if it was previously broken, a new install request will fix it.

@umbynos umbynos merged commit 6287df1 into main Aug 5, 2024
42 checks passed
@umbynos umbynos deleted the fix-esptool branch August 5, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: linux Specific to Linux operating system os: macos Specific to macOS operating system topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Esptool: No such file or directory" error when uploading code to ESP8266 board
4 participants