Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy lints #504

Merged
merged 9 commits into from
Aug 31, 2024
Merged

Fix clippy lints #504

merged 9 commits into from
Aug 31, 2024

Conversation

0e4ef622
Copy link
Contributor

@0e4ef622 0e4ef622 commented Aug 4, 2024

Replace std::*::EPSILON with *::EPSILON, etc.

@0e4ef622 0e4ef622 force-pushed the fix-clippy branch 2 times, most recently from 8ace747 to ada37fd Compare August 4, 2024 20:21
@0e4ef622
Copy link
Contributor Author

0e4ef622 commented Aug 4, 2024

Not exactly sure what to do about the remaining CI failures.

@stefan-k
Copy link
Member

Thanks for your work and apologies for the long wait!

The argmin-math tests are broken due to #509, will have to fix that in another PR or I may just do it in this one.

@stefan-k stefan-k force-pushed the fix-clippy branch 3 times, most recently from ed347fc to 30bea6c Compare August 31, 2024 09:07
@stefan-k
Copy link
Member

Fixes #509

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 99.40476% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.49%. Comparing base (a9e3eb7) to head (e031083).

Files with missing lines Patch % Lines
crates/spectator/src/connection.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   92.08%   91.49%   -0.60%     
==========================================
  Files         178      178              
  Lines       24455    23623     -832     
==========================================
- Hits        22520    21613     -907     
- Misses       1935     2010      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefan-k stefan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! :)

@stefan-k stefan-k merged commit 302b814 into argmin-rs:main Aug 31, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants