Make the LineSearch gradient parameter in BFGS consistent with the impl #508
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to implement my own custom
Param
type, but useArray1<f32>
as the gradient type. However, the current constraints essentially force these types to be the same because theBacktrackingLineSearch
trait is only implemented for <G, F> not for <P, F>This PR fixes BFGS's constraints so that G is used consistently as the parameter to
BFGS
's associatedLineSearch