Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the LineSearch gradient parameter in BFGS consistent with the impl #508

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

dspyz-matician
Copy link
Contributor

@dspyz-matician dspyz-matician commented Aug 21, 2024

I want to implement my own custom Param type, but use Array1<f32> as the gradient type. However, the current constraints essentially force these types to be the same because the BacktrackingLineSearch trait is only implemented for <G, F> not for <P, F>

This PR fixes BFGS's constraints so that G is used consistently as the parameter to BFGS's associated LineSearch

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (a9e3eb7) to head (15d60af).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   92.08%   91.48%   -0.61%     
==========================================
  Files         178      178              
  Lines       24455    23623     -832     
==========================================
- Hits        22520    21612     -908     
- Misses       1935     2011      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefan-k stefan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@stefan-k stefan-k merged commit be2444e into argmin-rs:main Aug 31, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants