Feature/412 add faer rs backend #549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 177 177
Lines 23672 23672
=======================================
Hits 21806 21806
Misses 1866 1866 ☔ View full report in Codecov by Sentry. |
|
This is excellent, thank you! Rebasing on the current main should fix the failing CI. Could you add running the faer tests to the CI (section |
geo-ant
force-pushed
the
feature/412-add-faer-rs-backend
branch
from
03c5907 to
146db74
Compare
|
done and done, fingers crossed this works now :) |
|
Hi, not meaning to rush you, just checking in to see whether there's something else I can do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #412 add faer as math backend
This PR adds
faersupport to argmin-math.faeris a fast and rapidly evolving matrix backend that is gaining popularity in the numeric Rust ecosystem. I'm not associated with the project.I've closely followed the logic of the
nalgebraimplementation and even manually copied and translated the tests, so that the behavior of thenalgebraimplementation is kept with thefaerimplementation. The one exception I made is that aneye_likeidentity matrix can also be requested for non-square matrices without panicking. Otherwise I've kept the original behavior.All implementations are available on the owned
Mat<T>type and many (but not all) are available on the non-owning reference-typeMatRef<T>.