Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Live resource view #267

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Live resource view #267

wants to merge 6 commits into from

Conversation

jannfis
Copy link
Collaborator

@jannfis jannfis commented Jan 6, 2025

What does this PR do / why we need it:

This PR introduces functionality to provide live resource view from the agents to the control plane. There are still a few caveats with this, and some things to sort out.

The general architecture is documented here.

It's also the pre-requisite for other upcoming features, such as log view, resource actions and resource manipulation, this is why I'd like to have the code in early.

The CLI components to manipulate cluster secrets will be a follow-up PR.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

The CLI code for managing cluster secrets will be submitted in a different PR, thus, the code in here is potentially difficult to test.

Checklist

  • Documentation update is required by this PR (and has been updated) OR no documentation update is required.

@jannfis jannfis force-pushed the feat/live-resource-view branch from d83a0f9 to a7c58b7 Compare January 6, 2025 15:33
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 46.45914% with 688 lines in your changes missing coverage. Please review.

Project coverage is 48.22%. Comparing base (d16afb3) to head (aac6a5e).

Files with missing lines Patch % Lines
cmd/principal/main.go 0.00% 93 Missing ⚠️
principal/server.go 14.94% 68 Missing and 6 partials ⚠️
agent/inbound.go 10.25% 70 Missing ⚠️
cmd/cmdutil/log.go 0.00% 51 Missing ⚠️
internal/event/event.go 7.54% 49 Missing ⚠️
internal/argocd/cluster/informer.go 58.82% 26 Missing and 9 partials ⚠️
internal/resourceproxy/resourceproxy.go 72.00% 27 Missing and 8 partials ⚠️
principal/resource.go 70.17% 27 Missing and 7 partials ⚠️
internal/argocd/cluster/conversion.go 42.30% 18 Missing and 12 partials ⚠️
cmd/cmdutil/term.go 0.00% 24 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   48.20%   48.22%   +0.02%     
==========================================
  Files          55       73      +18     
  Lines        5066     6268    +1202     
==========================================
+ Hits         2442     3023     +581     
- Misses       2424     2986     +562     
- Partials      200      259      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannfis jannfis force-pushed the feat/live-resource-view branch 2 times, most recently from 262d0e2 to ad9b02d Compare January 8, 2025 17:08
@jannfis jannfis force-pushed the feat/live-resource-view branch from ad9b02d to 1bd19ed Compare January 9, 2025 02:00
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
@jannfis jannfis marked this pull request as ready for review January 14, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants