-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Live resource view #267
Open
jannfis
wants to merge
6
commits into
main
Choose a base branch
from
feat/live-resource-view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannfis
force-pushed
the
feat/live-resource-view
branch
from
January 6, 2025 15:33
d83a0f9
to
a7c58b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 48.20% 48.22% +0.02%
==========================================
Files 55 73 +18
Lines 5066 6268 +1202
==========================================
+ Hits 2442 3023 +581
- Misses 2424 2986 +562
- Partials 200 259 +59 ☔ View full report in Codecov by Sentry. |
jannfis
force-pushed
the
feat/live-resource-view
branch
2 times, most recently
from
January 8, 2025 17:08
262d0e2
to
ad9b02d
Compare
Signed-off-by: jannfis <[email protected]>
jannfis
force-pushed
the
feat/live-resource-view
branch
from
January 9, 2025 02:00
ad9b02d
to
1bd19ed
Compare
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
jannfis
requested review from
jgwest,
ishitasequeira and
chetan-rns
as code owners
January 14, 2025 01:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it:
This PR introduces functionality to provide live resource view from the agents to the control plane. There are still a few caveats with this, and some things to sort out.
The general architecture is documented here.
It's also the pre-requisite for other upcoming features, such as log view, resource actions and resource manipulation, this is why I'd like to have the code in early.
The CLI components to manipulate cluster secrets will be a follow-up PR.
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:
The CLI code for managing cluster secrets will be submitted in a different PR, thus, the code in here is potentially difficult to test.
Checklist