fix: adjust connection for custom gRPC trigger #3421
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`grpc.NewClient` does not automatically connect to the gRPC server anymore. This is unlike the previously used `grpc.Dial`[1]. This change reintroduces initial connection test. [1]: https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md Signed-off-by: Michael Weibel <[email protected]>
whynowy
pushed a commit
that referenced
this pull request
Jan 10, 2025
Signed-off-by: Michael Weibel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc.NewClientdoes not automatically connect to the gRPC server anymore. This is unlike the previously usedgrpc.Dial1.This change reintroduces initial connection test.
I'm unsure whether we should actually do this, but at least it makes the code work again.
fixes #3420.
Checklist: