Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle retries where artifact already downloaded on prior try. Fixes #9257 #13908

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle retries where artifact already downloaded on prior try. Fixes #9257 #13908

wants to merge 1 commit into from

Conversation

tooptoop4
Copy link
Contributor

Fixes #9257

shuangkun
shuangkun approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@shuangkun shuangkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable. LGTM

@shuangkun shuangkun added the area/artifacts S3/GCP/OSS/Git/HDFS etc label Dec 20, 2024
tczhao
tczhao requested changes Dec 22, 2024
View reviewed changes
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix,
Could you refactor the logic so that we don't see repeating codes please

@shuangkun
Copy link
Member

Indeed, it would be better to simplify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tczhao tczhao tczhao requested changes

@shuangkun shuangkun shuangkun approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem on retryStrategy workflow when it used git artifact
3 participants
@tooptoop4 @shuangkun @tczhao