Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Fixed so that Hook is not retried when Workflow level Retry and Hook exist. Fixes #14058 #14060

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wjdwogjs999
Copy link

Fixes #14058.

Motivation

There are many problems when using Retry and Hook simultaneously at the workflow level.

  • As the DAG template did not operate properly, the first DAG template attempted did not fail, but a new DAG template was executed as a Running Hook child node.
  • Even if the workflow status changes to Success, the status of other Tasks within the DAG template that was initially started will remain Running and will not change.

Modifications

I don't know if it was intended to be able to retry all nodes within the workflow when setting up Retry at the workflow level.
This processing is causing many issues. So, I modified it so that the Retry setting is not applied to the Hook when setting the Retry at the Workflow level.
The workflow picture after application is as follows.
image

I have a question I would like to ask.

  • Was this implemented as part of the workflow level retry setting so that if Template Retry does not exist when setting the workflow level retry?
  • Is it intended to be retried for workflow-level retry hooks as well?
  • I think it would be good to add content that can determine whether the template being executed within executeTemplate is a hook or not.

Verification

You can check that it is running normally as shown below.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dag Template does not work properly when executing Workflow level Retry settings and Hook settings.
1 participant