Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Added Artifact Hub badge to readme #9793

Merged
merged 2 commits into from
Oct 13, 2022
Merged

chore: Added Artifact Hub badge to readme #9793

merged 2 commits into from
Oct 13, 2022

Conversation

eddie-knight
Copy link
Contributor

@eddie-knight eddie-knight commented Oct 11, 2022 •
edited
Loading

Part of #9769

Signed-off-by: Eddie Knight [email protected]

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

@eddie-knight eddie-knight marked this pull request as ready for review October 11, 2022 18:56
@eddie-knight eddie-knight force-pushed the chore/artifact-hub-badge branch from 0a144d8 to 7011582 Compare October 11, 2022 18:57
@eddie-knight
Copy link
Contributor Author

Got an e2e check failure that I could diagnose... re-pushed to restart the checks

@eddie-knight
Copy link
Contributor Author

Different failure this time.

Assuming these changes are welcome, could I get a recommendation from a reviewer to help make my checks to go green?

tczhao
tczhao approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems to be some flaky tests

@terrytangyuan terrytangyuan enabled auto-merge (squash) October 13, 2022 18:57
@terrytangyuan terrytangyuan merged commit 069cad0 into argoproj:master Oct 13, 2022
@eddie-knight eddie-knight deleted the chore/artifact-hub-badge branch October 13, 2022 19:16
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
@juchaosong
chore: Added Artifact Hub badge to readme (argoproj#9793)
69f7e08 
Signed-off-by: Eddie Knight <[email protected]>
Signed-off-by: juchao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tczhao tczhao tczhao approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddie-knight @terrytangyuan @tczhao