Merged unshare refactor #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, we used to construct shared namespace paths purely from string operations; that is, --share pid,mnt=/foo would be reconstructed as --share pid=/foo/pid --share mnt=/foo/mnt. The problem with this approach is that this doesn't work well with magic links to file descriptors in /proc. Instead, we now open the directory path and use its file descriptor to open further nsfs files.
Merge done using the github UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually messed up when resolving merge conflicts on #102 and I don't have authorization to fix it in Snaipe's branch. Making my own draft PR just so the ref is reachable from my review jobs which require the fix.