Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to skip draining on tty close #105

Merged
merged 2 commits into from
Dec 23, 2024
Merged

add an option to skip draining on tty close #105

merged 2 commits into from
Dec 23, 2024

Conversation

mstory21
Copy link
Collaborator

When ssh connections to buses are terminated bst is blocking while
draining the pty. The signal handler does to run in this case and
the process hangs around until the bus is rebooted.

Added an option to control whether or not the pty is drained when
stdin is closed. The b5c bst invocation will pass --tty=-drain.

When ssh connections to buses are terminated bst is blocking while
draining the pty.  The signal handler does to run in this case and
the process hangs around until the bus is rebooted.

Added an option to control whether or not the pty is drained when
stdin is closed.  The b5c bst invocation will pass --tty=-drain.
@mstory21 mstory21 requested a review from Snaipe December 20, 2024 12:21
Copy link
Member

@Snaipe Snaipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, one nit.

Also, can you update the man page to document the new drain tty option?

tty.h Outdated Show resolved Hide resolved
Copy link
Member

@Snaipe Snaipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

@mstory21 mstory21 merged commit 3f97bb7 into main Dec 23, 2024
4 of 6 checks passed
@mstory21 mstory21 deleted the mstory.no-drain branch December 23, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants