Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix voxel gi #3024

Closed
wants to merge 3 commits into from
Closed

fix voxel gi #3024

wants to merge 3 commits into from

Conversation

e2002e
Copy link
Contributor

@e2002e e2002e commented Jul 22, 2024

This is a patch for the voxels module:

  • Fix occlusion being multiplied by voxels specular instead of material's specular.
  • Implements voxels shadows and also voxels refraction. Deals with material only illumination.
  • Fix screen space refraction depth test that made background only appear through transparent objects.
  • Removed the normalization of viewPos in the use of reflect / refract.
  • Compute the environment light in the voxelizer and pass it in the "voxels" image for accuracy.

TODO:

  • Voxels refraction only work with screen space refraction on, yet no hint is given in the UI.

Bugs:

  • Forward renderer has wrong coordinates for sampling the voxels resolving images, so it results in strange projections.
    The materials created with make_forward_base.py are working fine in deferred.

@e2002e
Copy link
Contributor Author

e2002e commented Jul 31, 2024

@lubos, you can merge than if you don't mind voxels not working in forward renderer.
Everything is functional in deferred,

@e2002e e2002e closed this Aug 1, 2024
@e2002e e2002e reopened this Aug 1, 2024
@e2002e e2002e closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant