Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump commons-compress to 1.21, to fix security issues, and related commons-* dependencies to align with docker-java:3.4.0 #1340

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

fabiobrz
Copy link
Collaborator

@fabiobrz fabiobrz commented Jan 4, 2025

Duplicates #1325 but using 1.27.1, since the one proposed by dependantbot is throwing a NoClassFound exception.

Short description of what this resolves:

See #1325

Changes proposed in this pull request:

  • commons-compress from 1.19 to 1.27.1

Fixes https://github.com/arquillian/arquillian-cube/security/dependabot?q=package%3Aorg.apache.commons%3Acommons-compress+manifest%3Acore%2Fpom.xml+has%3Apatch

@fabiobrz fabiobrz force-pushed the bump.commons-compress branch 2 times, most recently from 223991c to 44da509 Compare January 7, 2025 16:25
@gaol
Copy link
Collaborator

gaol commented Jan 8, 2025

The CI looks like does not pick up the latest dependency of commons-lang3:3.16.0, might relate to the cache setup in the github action ?

OK, please ignore above comment.

I clicked the re-run jobs button and from https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/re-running-workflows-and-jobs#about-re-running-workflows-and-jobs, it might use the same commit.

It looks that the update of the pull request does not trigger the action, maybe add types: [synchronize] to the workflow ? see: https://github.com/orgs/community/discussions/25796

@fabiobrz
Copy link
Collaborator Author

fabiobrz commented Jan 8, 2025

The CI looks like does not pick up the latest dependency of commons-lang3:3.16.0, might relate to the cache setup in the github action ?

OK, please ignore above comment.

I clicked the re-run jobs button and from https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/re-running-workflows-and-jobs#about-re-running-workflows-and-jobs, it might use the same commit.

It looks that the update of the pull request does not trigger the action, maybe add types: [synchronize] to the workflow ? see: https://github.com/orgs/community/discussions/25796

Hi @gaol - and thanks for your feedback. It seems to me the error is actually related to the fact that docker-java:3.4.0 would use commons-compress:1.19.0 and then commons-lang3:3.12.0 transitively, which in turn conflicts with the latest updates here.
I'll try to experiment a bit and push some changes, so that we're sure the GitHub workflow will run on latest commit.
Let's see how it goes...

@fabiobrz fabiobrz force-pushed the bump.commons-compress branch from 44da509 to b9860e9 Compare January 8, 2025 10:12
@fabiobrz fabiobrz requested a review from gaol January 8, 2025 10:25
@fabiobrz
Copy link
Collaborator Author

fabiobrz commented Jan 8, 2025

Hi @gaol - it seems this is the less invasive solution, i.e. to align with the set of commons-* that docker-java:3.4.0 is transitively using as part of the docker-java-core:3.4.0 direct dependencies.
CI checks are green, would you mind reviewing and merging in case you're fine with the changes?

@fabiobrz fabiobrz changed the title Bump commons-compress to 1.27.1, to fix security issues Bump commons-compress to 1.21, to fix security issues, and related commons-* dependencies to align with docker-jave:3.4.0 Jan 8, 2025
@fabiobrz fabiobrz changed the title Bump commons-compress to 1.21, to fix security issues, and related commons-* dependencies to align with docker-jave:3.4.0 Bump commons-compress to 1.21, to fix security issues, and related commons-* dependencies to align with docker-java:3.4.0 Jan 8, 2025
Copy link
Collaborator

@gaol gaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Upgrading commons-compress to 1.21 can get 4 out 5 security alerts out in that component.

And I saw your pr to upgrade commons in docker-java component: docker-java/docker-java#2378, we can upgrade the docker-java once a new release is out.

@gaol gaol merged commit d00dc68 into arquillian:main Jan 8, 2025
3 checks passed
@fabiobrz fabiobrz added this to the 2.0.0 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants