Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vcrpy dependency #72

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Remove vcrpy dependency #72

merged 3 commits into from
Jul 3, 2024

Conversation

replaceafill
Copy link
Contributor

This removes the vcrpy test dependency and replaces its YAML fixtures with unittest.mocks.

@replaceafill replaceafill requested a review from a team July 2, 2024 23:36
Dhwaniartefact
Dhwaniartefact approved these changes Jul 3, 2024
View reviewed changes
Copy link

@Dhwaniartefact Dhwaniartefact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@replaceafill replaceafill merged commit 3dcf65d into master Jul 3, 2024
8 checks passed
@replaceafill replaceafill deleted the dev/remove-vcrpy branch July 3, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhwaniartefact Dhwaniartefact Dhwaniartefact approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@replaceafill @Dhwaniartefact