Do not create amdSec when bag metadata is empty #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simulates the scenarios where a bag does not contain a bag-info.txt and bagit returns an empty dictionary for its info attribute or when reading the bag goes wrong and the create_mets_v2 script logs the problem but also returns an empty dictionary. These scenario raise the same exception shown in issue #1129.
In the create_mets_v2.create_object_metadata function, the bag_info
variable represents a list of dictionaries with bag information.
The problem is that a list like [{}] which should be ignored (no bag
metadata) is considered truth-y at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the creation and association of a
amdSecelement to theobjectsdirectory in thestructMapwhen the transfer bag metadata is missing or unreadable.Connected to archivematica/Issues#1129