Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(EMI-2026): Add homeViewTasksSection to success response when clearing a task. #6343

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

erikdstock
Copy link
Contributor

@erikdstock erikdstock commented Jan 9, 2025

Part of EMI-2026.

This PR adds the homeViewTasksSection field to our success response type so that we can refresh the home view with an updated task list when dismissing or acknowledging a task. Eigen PR to consume this new field and optimistically update forthcoming.

Somewhat confusingly I realized that I added this field to the taskOrError field. It is adjacent to the task on the non-error type but the field name implies that it is one thing - a task. Not sure if there is a better way here.

cc @artsy/emerald-devs
paired with @MrSltun on some of it.

@erikdstock erikdstock self-assigned this Jan 9, 2025
Copy link
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 🌟

An alternative could be to just return homeView instead and then get the section from there in the client. Similar to how a lot of mutations return me (example). Maybe this simplifies the return type 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants